Skip to content

[improve] Upgrade opensearch sink to client 2.16 and tests to use server 2.16.0#23312

Merged
dao-jun merged 2 commits intoapache:masterfrom
dlg99:opensearch_216
Sep 18, 2024
Merged

[improve] Upgrade opensearch sink to client 2.16 and tests to use server 2.16.0#23312
dao-jun merged 2 commits intoapache:masterfrom
dlg99:opensearch_216

Conversation

@dlg99
Copy link
Contributor

@dlg99 dlg99 commented Sep 16, 2024

Motivation

Support OpenSearch 2.16.0

Modifications

Upgraded opensearch sink to client 2.16 and updated tests to use server 2.16.0

Verifying this change

This change is already covered by existing tests, such as Pilsar-IO integration tests.

Does this pull request potentially affect one of the following parts:

OpenSearch client is upgraded to v.2.16.0, this only affects OpenSearch sink

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Already documented

Matching PR in forked repository

PR in forked repository: dlg99#20

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Sep 16, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.54%. Comparing base (bbc6224) to head (fb3397c).
Report is 586 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #23312      +/-   ##
============================================
+ Coverage     73.57%   74.54%   +0.97%     
- Complexity    32624    34294    +1670     
============================================
  Files          1877     1927      +50     
  Lines        139502   145043    +5541     
  Branches      15299    15863     +564     
============================================
+ Hits         102638   108129    +5491     
+ Misses        28908    28635     -273     
- Partials       7956     8279     +323     
Flag Coverage Δ
inttests 27.89% <ø> (+3.30%) ⬆️
systests 24.72% <0.00%> (+0.39%) ⬆️
unittests 73.89% <100.00%> (+1.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...e/pulsar/io/elasticsearch/ElasticSearchConfig.java 89.83% <100.00%> (-0.85%) ⬇️
...ient/opensearch/OpenSearchHighLevelRestClient.java 88.02% <ø> (-0.25%) ⬇️

... and 567 files with indirect coverage changes

@lhotari lhotari added this to the 4.0.0 milestone Sep 17, 2024
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dao-jun dao-jun merged commit bf53164 into apache:master Sep 18, 2024
@jcmfernandes
Copy link

This means that we can update https://pulsar.apache.org/docs/next/io-elasticsearch-sink/ as Pulsar can now use ES 8 and OS 2, right?

hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs ready-to-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants